Fix loading WWI scenario #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow players to load scenarios (and saves) even if the chosen AI type is not supported. In other words: "be liberal in what we accept." In longturn#746, trying to load a scenario using the "tex" AI failed because we don't build it for fc21. If the user really wants another AI, s.he can switch back in pregame. Scenarios that really want to lock down their AIs retain this capability.
"classic" is the only AI available in fc21 anyway. It's better to load the game slightly wrong than to fail to load it because of an unsupported AI type. See longturn#746.
There's no other AI in fc21. Closes longturn#746.
|
Is this problem in any of the other built-in scenarios that should be fixed now as well? |
No (and they'd load anyway). |
psampathkumar
requested changes
Nov 23, 2021
| // Get pointer to persistent name of the ai_type | ||
| return ai_name(fb); | ||
| } | ||
| auto fb = ai_type_by_name("classic"); |
There was a problem hiding this comment.
log a warning when doing this.
Requested by panch93 in longturn#748.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of patches related to Freeciv(.org)'s new AI types "threaded" and "tex" that are not supported in fc21. Basically we always fall back to the classic AI, and only mention "classic" in our scenarios.
Closes #746.
Test plan: